Suggestion on progressr

[HenrikBengtsson]

Hello,

while troubleshooting a false-positive CRAN NOTE, I noticed that you use:

if (requireNamespace("progressr", quietly = TRUE)) prog()

in several places. You can avoid the quite expensive(*) calls to requireNamespace("progressr", quietly = TRUE) if you do:

if (requireNamespace("progressr", quietly = TRUE)) {
  prog <- progressr::progressor(along = 1:((length(variables) + 2) * B))
} else {
  prog <- function() NULL
}

Then you can replace:

if (requireNamespace("progressr", quietly = TRUE)) prog()

with

prog()

(*) requireNamespace() hits the file system each time if progressr is not installed.

[mikolajsp]

Hi,

thanks for the suggestion, this is a very easy fix and we're just working on a new release, I'll try to do it today.

[mikolajsp]

Hopefully this is resolved in 96b3f3f.

[HenrikBengtsson]

LGTM. FYI, progressor() has steps argument, so you don't have to create an auxillary along argument. That is, you can use

prog <- progressr::progressor(steps = (length(variables) + 2) * B)

instead.

[mikolajsp]

Thanks! I'll change that as well.