Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Option to set dark theme / light theme / system default #75

Closed
neubland opened this issue Oct 1, 2020 · 4 comments
Closed
Assignees
Labels
Enhancement New feature or request UI/UX Related to appearance of the app and flyout.
Projects

Comments

@neubland
Copy link

neubland commented Oct 1, 2020

Right now it seems like system default is automatically used. This is fine and a good default. Many apps let you choose whether to use system default or manually override with dark/light theme. This would be nice for ModernFlyouts.

@ShankarBUS
Copy link
Member

ShankarBUS commented Oct 1, 2020

The problem is where should that setting apply to??

We have the flyout following System Theme (would be similar to TaskBar, ActionCenter & etc) and the Settings Window following App Theme (would be similar to other apps)

Should there be two options? Like
Flyout theme :

  • Dark
  • Light
  • System Default

Settings Theme :

  • Light
  • Dark
  • System Default

Since Windows 8, the inbuilt flyout is dark. Most of the apps are light by default. That's why I switched them above.

Currently the settings window is so cluttered and unorganized. This may be a priority for v0.10.0

@neubland
Copy link
Author

neubland commented Oct 1, 2020

To be honest, I don't want to customize the settings page, I want to customize the flyout, and only the flyout. I propose the option to change the flyout theme and leave the settings theme untouched (which is following app theme, I gather?). Optimally a user uses the settings page on first use and rarely after that anyway.

@ShankarBUS
Copy link
Member

I know for sure you would say this. I wanted to actually implement this feature in v0.1.0 but dropped the idea (Since then this project didn't have much of attention or users). Would reconsider this 😁

@ShankarBUS ShankarBUS self-assigned this Oct 1, 2020
@ShankarBUS ShankarBUS added Enhancement New feature or request UI/UX Related to appearance of the app and flyout. labels Oct 1, 2020
@Samuel12321 Samuel12321 added this to To do in v0.8.0 via automation Oct 3, 2020
@Samuel12321 Samuel12321 added this to the 0.8 milestone Oct 3, 2020
@ShankarBUS ShankarBUS removed this from the 0.8 milestone Oct 11, 2020
@ShankarBUS ShankarBUS moved this from To do to In Progress in v0.8.0 Oct 22, 2020
@ShankarBUS ShankarBUS moved this from In Progress to Done in v0.8.0 Oct 29, 2020
@ShankarBUS
Copy link
Member

ShankarBUS commented Oct 31, 2020

@neubland,

Your request is implemented in 2dd9139.
Thank you so much for opening this feature request. Please give us new suggestions and ideas or file bug issues if you have time in the future 😄. Seeing active users and interacting with them on GitHub motivates us to improve this app. Thanks again for giving our app a try 😁.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request UI/UX Related to appearance of the app and flyout.
Projects
No open projects
v0.8.0
  
Done
Development

No branches or pull requests

3 participants