Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for GH marketplace #150

Open
grgur opened this issue Sep 9, 2019 · 4 comments
Open

Prepare for GH marketplace #150

grgur opened this issue Sep 9, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@grgur
Copy link
Member

grgur commented Sep 9, 2019

Here's the Marketplace publishing howto. One thing I noticed is that Dockerfile needs to be well commented.
Let's prepare Gimbal for Marketplace so we can publish when ready.

@grgur grgur added the enhancement New feature or request label Sep 9, 2019
@mitchellsimoens
Copy link
Collaborator

We will need to copy in a couple files like the license and readme like they do in this Dockerfile.

@mitchellsimoens
Copy link
Collaborator

I also think we need to look at how we are going to publish the action. Right now, we are saying to use uses: ModusCreateOrg/gimbal/action@master which will always use latest and greatest which may not be stable. Now this will use latest deployed gimbal but there could be changes in the version in master that has pending changes needed for gimbal that hasn't been replaced.

Since we use tags for publishing, you can target a specific gimbal via uses: ModusCreateOrg/gimbal/action@v1.2.3 however there is a version mismatch in the action's Dockerfile since it uses FROM moduscreate/gimbal:latest, we'll need to replace that latest with a version when we publish and before the git tag is created.

@grgur
Copy link
Member Author

grgur commented Sep 10, 2019

I would hope that some of this would be automatic given that GitHub requires cutting a new release

@mitchellsimoens
Copy link
Collaborator

A new release is just a tag. Like instead of @master, you can use a tag like @1.2.3 that we have right now without anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants