Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page-counter does not work in Paged.js #258

Open
henriette-einstein opened this issue Jun 15, 2020 · 2 comments
Open

page-counter does not work in Paged.js #258

henriette-einstein opened this issue Jun 15, 2020 · 2 comments
Labels
🐛 bug Something isn't working 🙃 upstream

Comments

@henriette-einstein
Copy link

The counter() function is Paged.js does not work as expected.

The following document uses the counter "page" that is initially set to 0 in the body selector

      body {
        counter-reset: page;
      }

It is then again set to 1 when the div with id "#content' is found in the document

      #content {
        counter-reset: page 1;
        hyphens: auto;
      }

The counter is used to display the page number on the bottom of the content pages.

Expected behavior:
The content pages should be numbered starting with 1 on the bottom of the content pages.

Actual behavior:
The page numbers are incorrect. Look at the test document attached to this issue.

test-pagenumber.html.zip

This issue is not related to asciidoctor-web-pdf directly but instead to the underlying paged.js library.

@ggrossetie
Copy link
Owner

A new version of Paged.js is out with fixes on counter-reset and counter-increment.
I will try to upgrade as soon as I get the chance. Hopefully, this issue should be fixed.

@ggrossetie ggrossetie added 🐛 bug Something isn't working 🙃 upstream labels Jun 22, 2020
@ggrossetie
Copy link
Owner

Just gave it a try but this issue is not fixed.
Upstream issue: https://gitlab.pagedmedia.org/tools/pagedjs/issues/220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🙃 upstream
Projects
None yet
Development

No branches or pull requests

2 participants