Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine granular Intersection calculation required #59

Closed
ariellev opened this issue Mar 23, 2020 · 6 comments
Closed

Fine granular Intersection calculation required #59

ariellev opened this issue Mar 23, 2020 · 6 comments

Comments

@ariellev
Copy link

ariellev commented Mar 23, 2020

At the current release, the criterion for finding an intersection between a corona carrier to a given user on the production environment is "500 meter for 1 millisecond", which obviously does not make any sense.

./config/config.ts

Is:

{
..
   meterRadius: 500,
    intersectMilliseconds: 1, // 1 milli
}

Should:

{
..
   meterRadius: 10,
    intersectMilliseconds: 1000 * 60 * 15, // e.g. 15 minutes 
}
@ItayElgazar
Copy link

why 10? meterRadius should be 2

@ariellev
Copy link
Author

Of course GPS signals tend to hope, so we need to account for that

@ItayElgazar
Copy link

Still don't get why 10 :) from where did you get this number?

@ariellev
Copy link
Author

intuition, like 2 meters would be the ideal case, I agree, but I am not sure it's realistic taking into account GPS hoping. So I would recommend to drop the radius to the 10-20 meters area, and keep on optimizing from there.

@henry-hz
Copy link

ops, just sent a PR for 200m, because we walk 100m in 1 min, and it's feasible to think that people leave the celular in the car, or near him. 10m doesn't cover the GPS lack of accuracy... see here and here

@yehudit-vizel-Moh
Copy link

Thanks @ariellev, @ItayElgazar and @henry-hz !

See more details here:
#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants