✨ Feature: add server response headers for CORS #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molunerfinn
reviewed
Jul 16, 2022
| 'Content-Type': 'application/json', | ||
| 'access-control-allow-headers': '*', | ||
| 'access-control-allow-methods': 'POST, GET, OPTIONS', | ||
| 'access-control-allow-origin': '*' |
There was a problem hiding this comment.
'*' will not work in some cases.
Use the referer or host of the request will be better, so called dynamic cors.
However, '*' can face many cases so I will merge this PR. We will upgrade it when needed.
|
您好，邮件已收到，我将尽快查阅。若有紧急事项，请电话通知。
|
|
Thanks for contribution! The next time use https://github.com/PicGo/bump-version will be better! |
Molunerfinn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using PicGo for uploading my image to qiniu in obsidian ( A markdown editor )，but I got a CORS error, as the PicGo server is designed for local upload, It may should allow any of origin.
this can resolve this case.
what do you think of cors ? should it be an item of config or just set '*' for any origin ?