Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopting FedCM regarding Chrome blocking third party cookies in future. Seeing warnings: Chrome will block third party cookies #333

Open
rjtbansal opened this issue Feb 22, 2024 · 6 comments

Comments

@rjtbansal
Copy link

rjtbansal commented Feb 22, 2024

Firstly thanks for this awesome library! I am using it for Google SSO on our web app.

Do we plan to make tweaks to the library for adopting FedCM https://developers.google.com/identity/gsi/web/guides/fedcm-migration?

Here's the Google docs that talk about third party cookies
https://developers.google.com/identity/gsi/web/guides/supported-browsers#third-party_cookies

Here's the migration guide:
https://developers.google.com/identity/gsi/web/guides/fedcm-migration#migrate_your_web_app

As an example below the screenshot I see when Google icon loads using this library:
image

@rjtbansal rjtbansal changed the title Regarding Chrome blocking third party cookies in future. Seeing warnings: Chrome will block third party cookies Adopting FedCM regarding Chrome blocking third party cookies in future. Seeing warnings: Chrome will block third party cookies Feb 22, 2024
@MuhammadAakash
Copy link

I have also received an email from Google to migrate to the FedCM over my website. I am using this library for the Google sign-in, and One Tap Sign in feature.

@MuhammadAakash
Copy link

@MomenSherif
I'm interested in contributing to this excellent library. Could you please guide me a little bit on how to address this current issue?
And I'm unable to find any references on how to set up the project and contribute to it.

Thanks

@VaibhavTessell
Copy link

@rjtbansal @MuhammadAakash I think they have already integrated FedCM in the library in this PR: #316

@VaibhavTessell
Copy link

VaibhavTessell commented Apr 10, 2024

<GoogleLogin
    clientId="CLIENT_ID"
    text="Sign in with Google"
    onSuccess={onSuccessHandler}
    onError={onFailureHandler}
    ux_mode="redirect"
    useOneTap
    auto_select

    // New Addition for FedCM integration
--> containerProps={{ allow: "identity-credentials-get" }}
--> use_fedcm_for_prompt

/>

After adding the containerProps and use_fedcm_for_prompt Google login started working with FedCM integration.

@rjtbansal @MuhammadAakash

@rjtbansal
Copy link
Author

@VaibhavTessell This is great as I dont see those warnings anymore! Just for the knowledge if possible could you please share how did you identify containerProps to be the fix?

@ssteuteville
Copy link

how would i do this for the auth code flow, not seeing how to do that with GoogleLogin and don't see any props available for fedcm with useLogin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants