Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Match Result Reply with Match Status #38

Closed
TylerBloom opened this issue Sep 4, 2022 · 2 comments
Closed

[Feat]: Match Result Reply with Match Status #38

TylerBloom opened this issue Sep 4, 2022 · 2 comments
Assignees
Labels
feature Some new is requested good first issue Good for newcomers

Comments

@TylerBloom
Copy link
Member

TylerBloom commented Sep 4, 2022

When a match result is entered (and maybe even when its confirmed), the reply should include a match status embed. That way, players know what they are entering/confirming.

@TylerBloom TylerBloom added good first issue Good for newcomers feature Some new is requested todo Will be resolved but work hasn't started labels Sep 4, 2022
@TylerBloom TylerBloom added this to the Version 2.0 Release milestone Sep 4, 2022
@Ben-Ostrovsky
Copy link

Hi Tyler. I can create a draw instance, if you like. Which file(s) should I look into for this?

@TylerBloom
Copy link
Member Author

Hi @Ben-Ostrovsky, currently the embed creation for a match (and most things) is not well encapsulated. Currently, the only place that creates match embeds is the match status updater, which used the update_match_message function found in src/utils/embeds.rs.

The first step would be to separate out the creation of the match embed into its own method or function. It would be helpful to have #40 done for that process. Then, the reply messages for the match-result and confirm-result` commands would need to call that new function.

@TylerBloom TylerBloom removed the todo Will be resolved but work hasn't started label Sep 29, 2022
@TylerBloom TylerBloom self-assigned this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Some new is requested good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants