Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Commanders not in Deck Embed #54

Closed
TylerBloom opened this issue Nov 19, 2022 · 1 comment
Closed

[Feat]: Commanders not in Deck Embed #54

TylerBloom opened this issue Nov 19, 2022 · 1 comment
Labels
feature Some new is requested good first issue Good for newcomers todo Will be resolved but work hasn't started

Comments

@TylerBloom
Copy link
Member

Description:

Currently, commanders don't appear in deck embeds. This is because the sorted deck struct only consumes the mainboard of a deck.

The solution you'd like:

The sorted deck should also track commanders.
@TylerBloom TylerBloom added good first issue Good for newcomers feature Some new is requested todo Will be resolved but work hasn't started labels Nov 19, 2022
@TylerBloom TylerBloom assigned TylerBloom and unassigned TylerBloom Nov 19, 2022
@TylerBloom
Copy link
Member Author

Closed by b56138c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Some new is requested good first issue Good for newcomers todo Will be resolved but work hasn't started
Projects
Squire Tournament Services
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TylerBloom