Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relevant column name not printed when a CSV parsing error occurs #4067

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

Relevant column name not printed when a CSV parsing error occurs #4067

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2016-09-16 10:28:16 +0200
From: @eyalroz
To: SQL devs <>
Version: 11.23.7 (Jun2016-SP1)
CC: @njnes

Last updated: 2016-10-24 23:35:08 +0200

Comment 22374

Date: 2016-09-16 10:28:16 +0200
From: @eyalroz

User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
Build Identifier:

When you COPY INTO from a CSV file, using mclient, and the parsing of a certain field fails, you get a message saying something like:

"Failed to import table line 1 field 13 'smallint' expected in '1247801'"

This could be improved in more than one way, but the most significant drawback is the lack of a column name. At this point, clearly the server knows/can know which column the value should go into (otherwise it would not know the type); it would be very helpful for the user to print the column name as well as the index (especially since it's not trivial to determine whether the field index is 1-based or 0-based), and columns in MonetDB are not typically identified using indices.

Reproducible: Always

Comment 22375

Date: 2016-09-16 11:05:25 +0200
From: @sjoerdmullender

This has nothing to do with the client.

Comment 22376

Date: 2016-09-16 11:06:25 +0200
From: @sjoerdmullender

Please don't add my name to the cc list. I get the notifications by other means already.

Comment 22394

Date: 2016-09-29 14:54:36 +0200
From: MonetDB Mercurial Repository <>

Changeset 4654b49d2101 made by Niels Nes niels@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=4654b49d2101

Changeset description:

approved output for new copy into error message.
Fixes bug #4067

Comment 22395

Date: 2016-09-29 14:54:51 +0200
From: @njnes

we now include the name of the field

Comment 24494

Date: 2016-10-13 10:04:14 +0200
From: @sjoerdmullender

Jun2016-SP2 has been released.

Comment 24618

Date: 2016-10-24 23:35:08 +0200
From: @eyalroz

Sorry for not making this comment earlier, but - why not print both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant