Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting and additional GitHub integrations #3

Merged
merged 34 commits into from Mar 27, 2022
Merged

Add linting and additional GitHub integrations #3

merged 34 commits into from Mar 27, 2022

Conversation

alexwaibel
Copy link
Contributor

@alexwaibel alexwaibel commented Mar 27, 2022 •
edited

Description of the change

Adds linting, formatting, and various GitHub integrations such as devcontainer setup.

  • Adds formatting and linting for ts and tsx files
    • Pre-commit hooks to automatically run these utils
    • GH actions to run these on PRs and merges to main
  • Adds devcontainer docker config for use locally and with GH Codespaces
  • Replace npm with yarn for various dependency management improvements

Benefits

  • Enforced consistent style and formatting
  • Ability to develop in a docker container on any platform
  • Faster dependency installs

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

@alexwaibel alexwaibel linked an issue Mar 27, 2022 that may be closed by this pull request
Add JS/TS linting and formatting #2
Closed
@alexwaibel alexwaibel self-assigned this Mar 27, 2022
@alexwaibel alexwaibel added the enhancement New feature or request label Mar 27, 2022
@alexwaibel alexwaibel added this to In progress in Business Factory Development via automation Mar 27, 2022
@alexwaibel alexwaibel marked this pull request as ready for review March 27, 2022 20:02
@alexwaibel alexwaibel requested a review from Dyrk33 as a code owner March 27, 2022 20:02
Dyrk33
Dyrk33 reviewed Mar 27, 2022
View reviewed changes
Copy link

@Dyrk33 Dyrk33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

behm39
behm39 approved these changes Mar 27, 2022
View reviewed changes
Copy link

@behm39 behm39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Business Factory Development automation moved this from In progress to Reviewer approved Mar 27, 2022
@alexwaibel alexwaibel merged commit 88360e8 into main Mar 27, 2022
@alexwaibel alexwaibel deleted the aw/add-linting branch March 27, 2022 20:05
Business Factory Development automation moved this from Reviewer approved to Done Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dyrk33 Dyrk33 Dyrk33 left review comments

@behm39 behm39 behm39 approved these changes

Assignees

@alexwaibel alexwaibel

Labels
enhancement New feature or request
Projects
Business Factory Development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JS/TS linting and formatting
3 participants
@alexwaibel @behm39 @Dyrk33