A get_or_create replacement

[BeardedSteve]

So #300 has been done, get_or_create has gone, good riddance.

The behaviour is still very useful and can be achieved with an upsert. However, whereas get_or_create returned a document, update_one with full_result=True returns a dict with some info about the result of the operation.

This has led me to write something like this a few times:

query = Hooman.objects(name="Charlie", job="Winning")
man_update = query.update_one(name="Charlie", job="Winning", upsert=True, full_result=True)
if man_update['updatedExisting']:
    da_man = query.get()
else:
    da_man = Hooman.objects.with_id(man_update['upserted'])

Three questions:

1. Is this the best way to do this?
2. If it is the best way (or the best way is similar number of keystrokes) can the above code be generalised to method somewhere in mongoengine?
3. If it can be included, where might be the best place?

My proposed answers:

1. Probably not but close enough
2. Yes that would be nice
3. Add an upsert_one method on BaseQuerySet (Upsert one #1167)

Appreciate any thoughts.

EDIT: For anyone finding this in future I changed point 3 above to match the accepted PR #1167

[decklord]

+1