Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request]: Consistent curly brace + vertical pipe ligature compared to non-ligature. #242

Closed
martinemde opened this issue Nov 17, 2023 · 6 comments
Closed

[Feature request]: Consistent curly brace + vertical pipe ligature compared to non-ligature. #242

martinemde opened this issue Nov 17, 2023 · 6 comments
Assignees
@MarcusSterz
Labels
enhancement New feature or request

Comments

@martinemde
Copy link

martinemde commented Nov 17, 2023 •
edited

What feature are you proposing?

In Ruby, this is very common and doesn't look great:

Screenshot 2023-11-17 at 12 34 38 PM

Compared with ligatures turned off.

Screenshot 2023-11-17 at 12 35 43 PM

Neither are pretty. Any ideas?
@martinemde martinemde added the enhancement New feature or request label Nov 17, 2023
@bebraw
Copy link
Contributor

bebraw commented Nov 17, 2023

It might be worth checking how Fira Code and others solve it to come up with a solution.

Somehow the ligature seems off when compared with }.

@okonet
Copy link

okonet commented Nov 17, 2023

We should align the | and make it taller. Let's discuss internally.

@martinemde
Copy link
Author

Fira Code, for reference (with ligatures enabled):

Screenshot 2023-11-17 at 1 25 47 PM

@MarcusSterz
Copy link

Yes, let's align the bar to match the brackets. We can make the traditional bar position a stylistic set if needed.

@martinemde
Copy link
Author

I downloaded the preview and it looks great.

@bebraw
Copy link
Contributor

bebraw commented Dec 15, 2023

Fixed in 2.012.

@bebraw bebraw closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcusSterz MarcusSterz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@martinemde @okonet @bebraw @MarcusSterz