Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust - .., .= and ..= ligatures don't fit together #50

Closed
bebraw opened this issue Dec 15, 2020 · 4 comments
Closed

Rust - .., .= and ..= ligatures don't fit together #50

bebraw opened this issue Dec 15, 2020 · 4 comments

Comments

@bebraw
Copy link
Contributor

bebraw commented Dec 15, 2020

To quote:

One thing that annoys me are ligatures for ".=". There are two range operators in Rust: ".." for a right-exclusive range and "..=" for a right-inclusive range and when I use the latter dots are displayed vertically in the middle. Otherwise, it is awesome and no other fixes/improvements come to my mind right now.

@bebraw bebraw removed their assignment Mar 2, 2021
@MarcusSterz
Copy link

@bebraw Can you help me with this one? Not sure what the user means by ‘dots are displayed vertically in the middle’.
We already have a double period ligature. On a scale from 1-10 how important is it to change it to match ‘..=’?
Will this create a discrepancy somewhere else?

@bebraw
Copy link
Contributor Author

bebraw commented Jul 20, 2021

@MarcusSterz That's a great point. Would it make sense to have a stylistic set specifically for Rust where we would override .. with the non-ligature one? In this case we would have to identify which ligatures make most sense to enable for Rust specifically but we would have to figure out the exact set somehow. I think #1 is related and @mitsuhiko is probably the right person to comment on Rust support.

@bebraw
Copy link
Contributor Author

bebraw commented Nov 24, 2023

There's a prerelease with a potential fix.

The core of the issue has to do with the combinations of .., .= and ..= which feel like a group. The problem is that we don't understand the meaning of these in many languages so the issue needs more research.

@bebraw
Copy link
Contributor Author

bebraw commented Dec 15, 2023

Included in 2.012. The exact ligatures added are +=, -=, *=, %=, &=, &^, and &^=.

@bebraw bebraw closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants