Skip to content

Commit

Permalink
Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
bkrodgers committed Mar 1, 2016
1 parent bf2e912 commit 4753d98
Showing 1 changed file with 20 additions and 3 deletions.
23 changes: 20 additions & 3 deletions assets/custom-types/remote-route53/remote_route53.js
Expand Up @@ -13,7 +13,12 @@ exports.handler = function(event, context) {
} else {
errMsg = "unknown resource type: " + args.ResourceType;
console.log(errMsg);
response.send(args, context, response.FAILED, errMsg);
if (args.ResourceType == 'Delete') {
// Report success, because we can never delete the stack otherwise.
response.send(args, context, response.SUCCESS, errMsg);
} else {
response.send(args, context, response.FAILED, errMsg);
}
}
};

Expand Down Expand Up @@ -204,15 +209,23 @@ var buildRecordSet = function(event) {
Type: event.ResourceProperties.Type
};
if (event.ResourceProperties.TTL) {
record.TTL = event.ResourceProperties.TTL;
if (typeof event.ResourceProperties.TTL === 'number') {
record.TTL = event.ResourceProperties.TTL;
} else {
record.TTL = parseInt(event.ResourceProperties.TTL);
}
}

if (event.ResourceProperties.SetIdentifier) {
record.SetIdentifier = event.ResourceProperties.SetIdentifier;
}

if (event.ResourceProperties.Weight) {
record.Weight = event.ResourceProperties.Weight;
if (typeof event.ResourceProperties.Weight === 'number') {
record.Weight = event.ResourceProperties.Weight;
} else {
record.Weight = parseInt(event.ResourceProperties.Weight);
}
}

if (event.ResourceProperties.Region) {
Expand All @@ -229,6 +242,10 @@ var buildRecordSet = function(event) {

if (event.ResourceProperties.AliasTarget) {
record.AliasTarget = event.ResourceProperties.AliasTarget;
// Comes in from CF as a string, needs to be a boolean
if (typeof record.AliasTarget.EvaluateTargetHealth === 'string') {
record.AliasTarget.EvaluateTargetHealth = record.AliasTarget.EvaluateTargetHealth.toLowerCase()=='true'?true:false;
}
}

if (event.ResourceProperties.HealthCheckId) {
Expand Down

0 comments on commit 4753d98

Please sign in to comment.