Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#99] Implement support for AWS::CloudFormation::Stack #100

Merged
merged 3 commits into from
Jun 13, 2016

Conversation

anelson
Copy link
Contributor

@anelson anelson commented Jun 6, 2016

Fixes #99 by adding support for AWS::CloudFormation::Stack

…templates can invoke other nested CF templates
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 50.539% when pulling 85cfc94 on anelson:issue_99 into 989b5c5 on MonsantoCo:master.

@@ -38,3 +38,23 @@ object `AWS::CloudFormation::WaitCondition` {
implicit val format: JsonFormat[`AWS::CloudFormation::WaitCondition`] = jsonFormat6(`AWS::CloudFormation::WaitCondition`.apply)
}

case class `AWS::CloudFormation::Stack`(name: String,
TemplateURL: Token[String],
TimeoutInMinutes: Option[Int] = None,
Copy link
Collaborator

@tjcorr tjcorr Jun 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the documentation at: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-stack.html it mentions the type should be a String. Do we need this to be a StringBackedInt?

@tjcorr
Copy link
Collaborator

tjcorr commented Jun 9, 2016

should we also include the NotificationARNs parameter?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 50.539% when pulling 271970b on anelson:issue_99 into 989b5c5 on MonsantoCo:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 49.959% when pulling 271970b on anelson:issue_99 into 989b5c5 on MonsantoCo:master.

@anelson
Copy link
Contributor Author

anelson commented Jun 13, 2016

made the requested PR changes

@tjcorr tjcorr merged commit 0dbf0f6 into Bayer-Group:master Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants