adding in all of the RDS engine and EBS volume types #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 4, 2016 09:23
# Conflicts: # src/main/scala/com/monsanto/arch/cloudformation/model/resource/RDS.scala
|
Where'd io2 come from? http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html links to http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateVolume.html for the list of types. I don't see io2 listed. |
|
Honestly I have no idea. My guess is it was a random typo back in the day that is long overdue to fix. |
|
Oh, duh. That's why you're removing it. I wasn't even paying attention to the colors, was thinking it was being added as a new thing. Mind's still on vacation a bit, I guess. This one LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.