Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EMR support #121

Merged
merged 4 commits into from Nov 30, 2016
Merged

Add EMR support #121

merged 4 commits into from Nov 30, 2016

Conversation

tylersouthwick
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 52.19% when pulling 4f29082 on tylersouthwick:emr into fa05312 on MonsantoCo:master.

@tylersouthwick tylersouthwick mentioned this pull request Nov 27, 2016
@bkrodgers
Copy link
Contributor

We do have an AmazonTag class already that could be used here instead of the new CloudformationTags. It does contain an optional PropagateAtLaunch parameter that doesn't apply in this case (it's for ASGs), but we're already using it in other places where it doesn't apply -- it defaults to None. I'd still say use it here though, and if we want to clean that up we can split it out in the ASG implementation.

@bkrodgers
Copy link
Contributor

Thanks for the quick change (and for all your contributions)! LGTM

@bkrodgers bkrodgers merged commit a09ed9b into Bayer-Group:master Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants