Iam policies - Add Conditions #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,4 +133,5 @@ package com.monsanto.arch.cloudformation | |||
|
|
|||
| package object model { | |||
|
|
|||
| implicit def lift2Option[A](a : A) : Option[A] = Option(a) | |||
There was a problem hiding this comment.
This allows not having to wrap arguments in a Some(...). I can remove it if you would rather not have it in there. It seems weird to have to do Some(Seq(...)) as opposed to just Seq(...)
|
This looks good to me. I merged in your other PRs and now this one has conflicts. Care to rebase? |
tylersouthwick
force-pushed
the
iam-policies
branch
from
c232300
to
b0791ad
Compare
tylersouthwick
force-pushed
the
iam-policies
branch
from
b0791ad
to
ff0e5dc
Compare
ddgenome
added a commit
that referenced
this pull request
Nov 23, 2015
Iam policies - Add Conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for IAM policy conditions