Add AWS::EC2::CustomerGateway support #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case class `AWS::EC2::CustomerGateway`( | ||
| name: String, | ||
| BgpAsn: Int, | ||
| IpAddress: String, |
There was a problem hiding this comment.
Can you make this more typesafe by using the new IPAddress type ( see https://github.com/MonsantoCo/cloudformation-template-generator/blob/master/src/main/scala/com/monsanto/arch/cloudformation/model/resource/EC2.scala#L235-L248).
|
I think I have it using IPAddress now. |
|
Please squash to a single commit and I'll get it merged and released. |
adamfokken
force-pushed
the
cgwsupport
branch
from
b1bdf66
to
ec247f6
Compare
|
The commits should be squashed. |
tjcorr
pushed a commit
that referenced
this pull request
Jan 19, 2016
Add AWS::EC2::CustomerGateway support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.