Fix Fn::Not, Fn::And, and Fn::Or
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Token[String] for now, but would like to narrow still
tjcorr
pushed a commit
that referenced
this pull request
Feb 2, 2016
Fix `Fn::Not`, `Fn::And`, and `Fn::Or`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls back a portion of #57 to fix #60. This only fixes it in the sense that it works again and adds unit tests for the cases that #57 broke. I'll leave #60 open as we'd like to add better type safety as was intended. However, I'm running into issues with getting it to work with all the implicits involved in the
AmazonFunctionCallandTokenconversions, and I need to move on for now.