Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross compile to 2.12 #21

Closed
wants to merge 5 commits into from
Closed

Cross compile to 2.12 #21

wants to merge 5 commits into from

Conversation

lustefaniak
Copy link

@lustefaniak lustefaniak commented Jun 22, 2017

Fixes #11

This is ready for library project.

For 2.11 it contains Spray and Akka-HTTP endpoint, for 2.12 only Akka-HTTP.

I'm not sure what should be done about demo project. I think best approach would be to move that project into separate repository. If that is not an option, similar approach as in library could be used and demo could be ported to akka-http.

There are still some deprecations about using JavaConversions in ProtoBufFormat, but changing it makes code a little bit less readable. I think it should be done using JavaConverters and breakOut to reduce allocations, but can happen in next PR.

@lustefaniak
Copy link
Author

sbt-doge skips demo from 2.12.2 build, all should be fine now.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 88.772% when pulling 77591d6 on lustefaniak:cross-compile-to-2.12 into 3b4a578 on MonsantoCo:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 88.772% when pulling 5af088f on lustefaniak:cross-compile-to-2.12 into 3b4a578 on MonsantoCo:master.

@lustefaniak
Copy link
Author

Hey @sattvik, do you think there is chance to get that merged and released? We are using 2.12 build in our applications for 2 months already and all is working fine. It would simplify our life if that was released upstream as now we are including copy of this codebase as module in sbt.

@bzumhagen
Copy link

bzumhagen commented Dec 1, 2017

Any chance we can get this merged now? Looks like it's approved?

@lustefaniak, @ElfoLiNk

@lukasz-golebiewski
Copy link

@ElfoLiNk What is preventing this PR from being merged?

@lustefaniak
Copy link
Author

Kamon 1.0 has now Prometheus support, so probably there is no point maintaining this.

@lustefaniak lustefaniak closed this May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants