New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross compile to 2.12 #21
Conversation
sbt-doge skips |
Hey @sattvik, do you think there is chance to get that merged and released? We are using 2.12 build in our applications for 2 months already and all is working fine. It would simplify our life if that was released upstream as now we are including copy of this codebase as module in sbt. |
Any chance we can get this merged now? Looks like it's approved? |
@ElfoLiNk What is preventing this PR from being merged? |
Kamon 1.0 has now Prometheus support, so probably there is no point maintaining this. |
Fixes #11
This is ready for
library
project.For 2.11 it contains Spray and Akka-HTTP endpoint, for 2.12 only Akka-HTTP.
I'm not sure what should be done about
demo
project. I think best approach would be to move that project into separate repository. If that is not an option, similar approach as inlibrary
could be used and demo could be ported to akka-http.There are still some deprecations about using JavaConversions in ProtoBufFormat, but changing it makes code a little bit less readable. I think it should be done using
JavaConverters
andbreakOut
to reduce allocations, but can happen in next PR.