ScalaJS support #11
Merged
ScalaJS support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you take a look at the failed travis build? |
|
will fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For anyone using scalaJS, using the same serializers and data types in client and server is a big boon. A bit of the code in mwundo relies on java libraries or scala libraries that do not work in scalajs (spray, breeze, jts), but everything else should work just fine.
The large majority of the change is just move things around. There is a backwards compatibility break introduced though, as the Utils class had both JVM-only and generally useful classes in it. Therefore, I split it in two, one in shared, the other JVM-only sources. Therefore, I recommend that more than just the patch level is moved up.