STYLE_GET seems broken

[PierreBrisorgueil]

Describe the bug
Not sure because it's my first test on it but STYLE_GET seems broken

To Reproduce

LET doc = DOCUMENT('https://news.ycombinator.com/', {
    driver: 'cdp',
    viewport: {
        width: 1920,
        height: 1080
    }
})


WAIT_ELEMENT(doc, '.storylink', 5000)

FOR el IN ELEMENTS(doc, '.title')
    RETURN STYLE_GET(el, 'font-family')

will return [{},{},{}...]

Expected behavior

font-family: Verdana, Geneva, sans-serif

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• Version: 0.11.1

[ziflex]

Could you try it in 0.12?

[PierreBrisorgueil]

@ziflex hello, same result on my side with ycombinator example

[{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{}]

example code checked quickly, seems good to me.

[d2bit]

Hi, I've took a look and seems to me it's the correct behaviour, as it's checking for the element styles.

@ziflex what do you think about adding COMPUTED_STYLE_GET to retrieve window.getComputedStyle?
So that all applied styles to an element will be inspected.

If you say so, I'll try to implement it.

[PierreBrisorgueil]

hoo, maybe you are right, I didn't even think about it, it is very rare to have properties directly on the element today, that would be a good idea 👍

[ziflex]

Hi, I've took a look and seems to me it's the correct behaviour, as it's checking for the element styles.

@ziflex what do you think about adding COMPUTED_STYLE_GET to retrieve window.getComputedStyle?

So that all applied styles to an element will be inspected.

If you say so, I'll try to implement it.

Can we think about adding an optional 3rd parameter to STYLE_GET?

Also, we would need to add a new property to a HTML element.

[PierreBrisorgueil]

if you add this I would advise enabling this option by default

[ziflex]

I wonder what implications might be if we always return computed styles?

[davad]

I think returning computed styles is the natural thing to do here. Most use-cases I can think of, you'd be interested in what styles are currently applied to an element.

The only use-case I can think for getting the style that's attached to a specific element would be UI testing (i.e. "assert that style X is attached to element Y"). Can anyone think of another use-case?

[ziflex]

Ok, I think the resolution would be this:

• STYLE_GET returns always computed values
• el.style - returns computed values
• el.attributes.style - returns styles defined in the element.

[PierreBrisorgueil]

seems good!

[ziflex]

@d2bit do you wanna take it?

[PierreBrisorgueil]

Thx :)