Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stop script execution on non HTTP 200 #553

Closed
JekRock opened this issue Sep 19, 2020 · 7 comments
Closed

Don't stop script execution on non HTTP 200 #553

JekRock opened this issue Sep 19, 2020 · 7 comments
Labels
area/drivers HTML drivers good first issue Good for newcomers help wanted Extra attention is needed type/enhancement New feature or request
Milestone

Comments

@JekRock
Copy link

JekRock commented Sep 19, 2020

Is your feature request related to a problem? Please describe.
Currently, there are services that secure website from automation tools like ferret. Some of them send 405 in response to the DOCUMENT function call that make a ferret script fail with an error even though a page is available (not the original page, but usually a page with the captcha).

Describe the solution you'd like
It would be nice to either have some kind of flag that will tell ferrret to ignore response codes and continue the script execution or to pass response codes to ignore as a parameter to the DOCUMENT function, for exemple.

Additional context
For the example with the captcha above, the script could have contunued the execution and wait for someone solving the captcha manually (in non-headless browser). It can be achieved by just calling a "wait for element" function.

@ziflex ziflex added area/drivers HTML drivers type/enhancement New feature or request labels Sep 21, 2020
@ziflex ziflex added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 11, 2020
@ziflex ziflex added this to the 0.14.0 milestone Nov 23, 2020
@ziflex
Copy link
Member

ziflex commented Feb 19, 2021

Hey, could you provide some links as examples?

@JekRock
Copy link
Author

JekRock commented Feb 20, 2021

Sure. Try this one.
It will very quickly open the page with captcha when you start to do anything with the page

@ziflex
Copy link
Member

ziflex commented Mar 1, 2021

hey, are you using CDP driver or in-memory one?
I see that Chrome handles these kind of pages.

@JekRock
Copy link
Author

JekRock commented Mar 1, 2021

I was using the CDP driver

@ziflex
Copy link
Member

ziflex commented Mar 1, 2021

What Chrome version?

@ziflex
Copy link
Member

ziflex commented Mar 5, 2021

I'm trying to reproduce it with CDP driver, but it's working fine.
Could you give me more information?

@ziflex
Copy link
Member

ziflex commented Mar 5, 2021

I added support to HTTP (InMemory) driver, but I don't see that it needs to be added to CDP.
Feel free to re-open.

@ziflex ziflex closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/drivers HTML drivers good first issue Good for newcomers help wanted Extra attention is needed type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants