Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python/ui: whole layer rarity #98

Open
Montspy opened this issue Jun 30, 2022 · 0 comments · May be fixed by #99
Open

python/ui: whole layer rarity #98

Montspy opened this issue Jun 30, 2022 · 0 comments · May be fixed by #99
Assignees
Milestone

Comments

@Montspy
Copy link
Owner

Montspy commented Jun 30, 2022

We should allow for the user to set a percentage of chance to not generate a whole layer.
Currently users have to create an empty trait with a fully transparent image.
This isn't ideal and this "Empty" variation still shows up in the attributes and properties.

Adding our previous discussion here:

Add a weights_total key. The chance of the layer being empty is then weights_total - sum(weights). If the weights_total key doesn't exist we assume weights_total = sum(weights) (this is to be compatible with old collections using named rarities that don't add up to 100% (Common, Rare, Legendary)

@Montspy Montspy added this to the 1.1.0 milestone Jun 30, 2022
@Montspy Montspy self-assigned this Jun 30, 2022
@Montspy Montspy linked a pull request Jul 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant