Various improvements #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 61.10% 62.87% +1.77%
==========================================
Files 28 28
Lines 1689 1767 +78
==========================================
+ Hits 1032 1111 +79
+ Misses 657 656 -1 ☔ View full report in Codecov by Sentry. |
|
@JuliaRegistrator register |
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21 , #24, #17
The main user-facing change is that we now support calling
zeroon any multivector type (andonefor even multivectors), and not just on existing values. As a consequence thezerosandonesfunctions for intialising arrays will 'just work', as noted in #24 .We also implement
LinearAlgebra.normfor all types (although not allowing anything other thanp=2for now). This is defined in a such a way that the norm will always be real, by taking the square root of the absolute value of the dot product.