Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Incorrect rendering if used with dark theme #85

Closed
xcslabs opened this issue Feb 7, 2024 · 2 comments · Fixed by #86
Closed

Incorrect rendering if used with dark theme #85

xcslabs opened this issue Feb 7, 2024 · 2 comments · Fixed by #86
Assignees
@Monviech
Labels
cleanup Refactoring something

Comments

@xcslabs
Copy link

xcslabs commented Feb 7, 2024

It seems that there is a glitch when used with dark theme (tested with cicada and vicuna):

Screenshot_20240207_203347
@Monviech
Copy link
Owner

Monviech commented Feb 7, 2024 •
edited

I guess it's because I hard coded the color of the div that encloses these elements. I can look at it.

os-caddy-plugin/usr/plugins/devel/caddy/src/opnsense/mvc/app/views/Pischem/Caddy/general.volt

Line 54 in 32c52bd

<div style="margin-top: 20px; width: 100%; background-color: white; padding: 5px; border: 1px solid #ddd;">

Here I put "background color white", also put it in other parts because I don't use any dark mode. I gonna clean this up.

@Monviech Monviech self-assigned this Feb 7, 2024
@Monviech Monviech added the cleanup Refactoring something label Feb 7, 2024
@Monviech Monviech linked a pull request Feb 8, 2024 that will close this issue
Route53 DNS Provider added + Dark Mode GUI fix #86
Merged
@Monviech
Copy link
Owner

Monviech commented Feb 8, 2024

Fixed in latest version. Thanks for the feedback ^^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Monviech Monviech

Labels
cleanup Refactoring something
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Route53 DNS Provider added + Dark Mode GUI fix Monviech/os-caddy-plugin
2 participants
@xcslabs @Monviech