Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender 3.4 Mix RGB Changes #358

Closed
StandingPadAnimations opened this issue Dec 7, 2022 · 3 comments · Fixed by #357
Closed

Blender 3.4 Mix RGB Changes #358

StandingPadAnimations opened this issue Dec 7, 2022 · 3 comments · Fixed by #357
Labels
enhancement Feature requests or new functionality suggestions
Milestone

Comments

@StandingPadAnimations
Copy link
Collaborator

@TheDuckCow pinging you on this issue since it relates to compatibility

Blender 3.4 has just been replaced, and with it the Mix RGB node has been replaced with a new Mix node. While Blender 3.4 should in theory convert Mix RGB automatically, it would be best if we don't have to rely on that conversion, considering how many materials MCprep works with.

@StandingPadAnimations StandingPadAnimations added the enhancement Feature requests or new functionality suggestions label Dec 7, 2022
@StandingPadAnimations StandingPadAnimations linked a pull request Dec 7, 2022 that will close this issue
@TheDuckCow
Copy link
Member

Oof. Thanks for the heads up, seems I have a lot of code to be updating even outside MCprep ha.

Does @zNightlord 's change completely address this to our knowledge, or just a subset?

@StandingPadAnimations
Copy link
Collaborator Author

StandingPadAnimations commented Dec 7, 2022

Oof. Thanks for the heads up, seems I have a lot of code to be updating even outside MCprep ha.

Same here, I got some error porting in one of my Rust projects 😅

Does @.zNightlord 's change completely address this to our knowledge, or just a subset?

The change introduced is a function that handles the difference between 3.4 Mix and the old Mix nodes (including sockets). As far as I can tell through my quick skim, it should essentially be seamless (though I haven't done a full review of the code yet).

@zNightlord
Copy link
Contributor

Merged. You can close this issue now 👍

@TheDuckCow TheDuckCow added this to the v3.4.2 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or new functionality suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants