-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nodegroup option in prep material #432
Comments
We already have #274 (which is half-developed and exists in the MCprep source code already) which allows users to create their own materials. The problem with a nodegroup is that it abstracts too much from the user, which goes against MCprep's design goals |
Yeah this idea of "custom" sounds abstract. Us someone can program, what we possibly no longer can or easily control the options essentially it jumps over the reflective, solid, emission, emissive nodes... From user perspective they don't have to convert something like LabPBR into code and even extends further to something like parrallax (oh dear) A forward version of sync material is you can directly work in your current blendfile change that nodegroup. The goal is to somehow make thing more convenient, migrate to more asset way. These are the idea image and one from the prototype which I added a few things |
From what I can tell, this behavior can be replicated with the Default Materials proposal (just create a default material with the nodegroup). There's not any reason to replace the current material setup with a group node (especially considering group nodes are harder to edit) |
If you don't count many things I strangely layouted in "How do you imagine your feature works?" yes it is likely adding another similiar feature, add another level nodegroup for material or customize material nodetree. I opened this issue after #431 so |
Even with "How do you imagine your feature works?", I don't see how this has to be seperate from custom default materials. When custom default materials is used (at least in the proposal), MCprep will only provide image textures, that's it. Default materials can be split per pack format (and I want to also allow users to be able to select any custom default material found in material.blend, so other formats could be supported too). The only advantage this proposal has is not hardcoding the pack formats, and again that could be done by extending the custom default materials proposal (heck, we could eliminate hardcoded material generation with custom default materials only, and that would be virtually identical to this, but far more flexible). This just seems like unnecesary abstraction in comparison |
With that I'll be closing this. I think it would be better to extend (or propose an alternative route) #274 |
Check against existing requests
Describe the context
This somewhat have been discussed before in Discord, a "Custom" shader for users to change or tweak rather hardcode like current pack formats and use in prep material, a more forward version of sync material.
Beside the nodegroup restructure this also bring mixing PBR textures as a feature later on.
This feature will be in exprimental flag as planned before.
Related to #431 since with this we can store LabPBR pack format as nodegroup.
How do you imagine your feature works?
Due to current code, Texgen functions are mixed with some extra "processor" depends on the pack format
...
What Texgen supposed to is only create the image texture nodes right?
So splits the texture nodes out, the rest in a shader nodegroup.
The default nodegroup sockets should exposed are: Diffuse, Alpha, Tint, Roughness, Metallic, Normal, Emission (Emission likely optional)
What about emission nodes?
So does it mean LabPBR, MER (Bedrock) or some custom water shader can easily added by the user?
What about current pack formats?
Why not put those existed pack formats into a blendfile?
Other questions like:
Since we are dropping 2.7, should we stop using the non principled "original" nodetree?
What existing workaround (or closest thing to a workaround) do you have today (within Blender, MCprep, or any software)? If there is no workaround, explain why you feel this way.
I think I already demonstrated everything. I will add images later if things are still unclear.
The text was updated successfully, but these errors were encountered: