This repository has been archived by the owner on May 31, 2021. It is now read-only.
Reverted change d8101729711ac6aab9b2e7072dda06856df99abd. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout fix for Windows effectively disabled all logging from a windows clients (mostly development machines). An integration test was performed to verify if the timeout could actually be reproduced, but this was not the case. It is unclear why this was occured previously.
|
Thanks so much for looking into this. Merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout fix for Windows effectively disabled all logging from a windows clients (mostly development machines).
An integration test was performed to verify if the timeout could actually be reproduced, but this was not the case.
It is unclear why this was occured previously.