Clonning era contracts repo and compiling locally system contracts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hojarasca
force-pushed
the
feat/locally-compile-l2-contracts
branch
from
0b51700
to
2760b92
Compare
hojarasca
changed the base branch from
refactor/consume-github-from-local-repo
to
chore/measure-test-coverage
hojarasca
force-pushed
the
feat/locally-compile-l2-contracts
branch
from
dbfc764
to
49b967b
Compare
hojarasca
changed the title
* improved tests * wip remove AbiSet * fmt:fix * removed dead code * improved tests for block explorer client * coverage over 50% * fmt fixe
tomimor
reviewed
May 31, 2024
There was a problem hiding this comment.
Please review:
-
We should specify
yarnas a new dependency. I was unable to run thecheckcommand for a missingyarnerror. After installation, everything runs smoothly. -
We need to review
Generating report…abi. See image.
- As we don't need further the Github API keys, lets keep in mind we should update the Readme also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR totally replace comparing contract hahes from pre compiled versions. Instead it always compiles and the use the calculted hashes to check if the upgrade is valid