Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency of classifier-free guidance between training and testing. #109

Open
TianpengBu opened this issue Mar 28, 2024 · 1 comment

Comments

@TianpengBu
Copy link

HI, authors,
Great work! My question about the implementation is as follows:

During training, I found that you randomly set 20% of CLIP's input as zeros tensors,
image

however, during testing, you concatenate the output of clip embedding with zero tensors, like this:
image

As far as I am concerned, to align the training and testing, should we randomly set 20% of the output of CLIP as zero tensors rather than the input of CLIP model?

@jiangzhengkai
Copy link

@TianpengBu I totally agree with you

@TianpengBu TianpengBu changed the title Inconsistency between classifier-free guidance between training and testing. Inconsistency of classifier-free guidance between training and testing. Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants