Implement Basic Metrics (#40) #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mordil
force-pushed
the
40-metrics
branch
2 times, most recently
from
cbaf95f
to
4406252
Compare
|
@tomerd @tanner0101 Does this look like a reasonable first stab at database metrics? |
Motivation: End users will want to capture some baseline performance metrics that can only be accurately gathered at this level of the stack. Modifications: Added new `RedisMetrics` struct that retains all SwiftMetrics objects used throughout the system lifecycle, and appropriate code to track desired metrics. Result: Users now have a way to peek into the system's performance to understand what NIORedis is being asked to do from their usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
End users will want to capture some baseline performance metrics that can only be accurately gathered at this level of the stack.
Modifications:
Added new
RedisMetricsstruct that retains all SwiftMetrics objects used throughout the system lifecycle, and appropriate code to track desired metrics.Result:
Users now have a way to peek into the system's performance to understand what NIORedis is being asked to do from their usage.