Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current error.py is not friendly or scalable #7

Closed
pybash1 opened this issue May 27, 2021 · 3 comments
Closed

Current error.py is not friendly or scalable #7

pybash1 opened this issue May 27, 2021 · 3 comments
Labels
bug Something isn't working
Projects

Comments

@pybash1
Copy link
Contributor

pybash1 commented May 27, 2021

The current error.py file contains a class which contains several functions for raising an error. This is not a very good practice. Also, you are using the cryptography library to get a error. Instead just create different classes for each exception and create your own exception instead of importing from cryptography for starting this is fine but after that not. To learn more about it refer here And here and here. If you feel like I am being to rude or bossy sorry, I like this library and am just highlighting a few issues which when fixed would make the library great.

@pybash1 pybash1 added the bug Something isn't working label May 27, 2021
@metamorphic-spyware
Copy link
Owner

metamorphic-spyware commented May 27, 2021

I'll do so tomorrow and don't think that at the end of the day you are just helping me and other people.
Thanks for pointing these things out,
Feel free to open any issue or pull request
See you with new update tomorrow,
~ Morgan-Phoenix

@metamorphic-spyware metamorphic-spyware added this to To do in Tracker via automation May 27, 2021
@metamorphic-spyware metamorphic-spyware moved this from To do to In progress in Tracker May 28, 2021
metamorphic-spyware added a commit that referenced this issue May 28, 2021
@metamorphic-spyware
Copy link
Owner

I have Made Changes,
Hope U Like It :-)

Tracker automation moved this from In progress to Done May 28, 2021
@metamorphic-spyware metamorphic-spyware removed this from Done in Tracker May 28, 2021
@metamorphic-spyware metamorphic-spyware added this to Needs triage in Bug Tracker via automation May 28, 2021
@metamorphic-spyware metamorphic-spyware moved this from Needs triage to Closed in Bug Tracker May 28, 2021
@pybash1
Copy link
Contributor Author

pybash1 commented May 28, 2021

yes that is way better..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants