Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error TS6133 when noUnusedParameters is set #2

Closed
royra opened this issue Jun 7, 2020 · 4 comments
Closed

Compilation error TS6133 when noUnusedParameters is set #2

royra opened this issue Jun 7, 2020 · 4 comments

Comments

@royra
Copy link

royra commented Jun 7, 2020

When the noUnusedParameters compiler option is set, I'm getting lots of these errors:

node_modules/tsargs/lib/pre-argn.ts:261:316 - error TS6133: 'J' is declared but its value is never read.

Edit: Added repro

@royra royra changed the title Compilation error when noUnusedParameters is set Compilation error TS6133 when noUnusedParameters is set Jun 7, 2020
@Morglod
Copy link
Owner

Morglod commented Jun 9, 2020

@royra hi
if you dont use something special from tsargs, you can use Parameters type for standart lib

https://www.typescriptlang.org/docs/handbook/utility-types.html#parameterst

@royra
Copy link
Author

royra commented Jun 10, 2020

@royra hi
if you dont use something special from tsargs, you can use Parameters type for standart lib

https://www.typescriptlang.org/docs/handbook/utility-types.html#parameterst

Not using tsargs directly, it's a dependency in another package I have no control on.

@mekwall
Copy link

mekwall commented Aug 25, 2020

I am getting this as well. I am using @Morglod's other package tsee which depends on this. I would recommend to build JS files with sourcemaps + declarations and publish that to npm instead of the source files. TypeScript parses declarations way faster than source files and most people have skipLibCheck enabled which will ensure these errors are ignored.

@Morglod
Copy link
Owner

Morglod commented Oct 20, 2020

@mekwall @royra just updated tsee and removed tsargs from it

@Morglod Morglod closed this as completed Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants