Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential packet overload issues with Apugli #16

Open
MerchantPug opened this issue Dec 20, 2022 · 7 comments
Open

Potential packet overload issues with Apugli #16

MerchantPug opened this issue Dec 20, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@MerchantPug
Copy link

MerchantPug commented Dec 20, 2022

Minecraft Version

1.19.2

Mod Version

v1.2.3

Mod loader

Fabric

Describe your issue

I wrote an issue for this to another Origins addon that uses Apugli as well but I'd highly recommend updating the integrated Apugli to the latest version as I've optimised some very unoptimised packets within the mod.

Basically one very unoptimised packet would trigger multiple times each tick for each individual value, in smaller settings this isn't noticeable but when you've got a larger entitybase, packet overload happens.

Solution

Update Apugli to latest. I've optimised the packets.

Crash report/logs

No response

@mosharky
Copy link
Collaborator

Heyy, I feel super bad since I know you already reminded me a bit ago haha. I'll have the time to sit down and update after the holidays. Thank you for reminding me again!

@MerchantPug
Copy link
Author

No problem, just thought I'd post this here as I saw you hadn't updated.

@Elfinlocks
Copy link

Currently experiencing packet overload crashes from this issue. If this could be patched that would be great.

@MerchantPug
Copy link
Author

MerchantPug commented Feb 15, 2023

I would recommend downloading Apugli separately for the time being, at least until the nested apugli has been updated here

@mosharky
Copy link
Collaborator

Pug reply to dms D:

@MerchantPug
Copy link
Author

MerchantPug commented Feb 16, 2023

I'm so sorry for leaving you on read, holy shit, it just slipped my mind.

@MerchantPug
Copy link
Author

This should be fixed once Apugli v1.13.2 releases, I've made a few issues that need to be ironed out within the previous two releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants