Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the package into two #9

Closed
Ascenio opened this issue Mar 4, 2022 · 3 comments
Closed

Split the package into two #9

Ascenio opened this issue Mar 4, 2022 · 3 comments
Assignees

Comments

@Ascenio
Copy link

Ascenio commented Mar 4, 2022

Hello. I've noticed the package does two things: it has widgets integrated with the once and also does the timer logic thing. This mean the package has a unnecessary dependency on Flutter, those running Dart only can't use it. So, it would be nice to split into once and once_flutter, something like that.

@MostafaSolimanMO
Copy link
Owner

It was there flutter_once. But the package once depends on SharedPreferences and it depends on Flutter so the separation would not be useful unless the depending on SharedPreferences changed.

@MostafaSolimanMO MostafaSolimanMO self-assigned this Mar 7, 2022
@Ascenio
Copy link
Author

Ascenio commented Mar 7, 2022

Oh, it does make sense. I thought the lib only managed scheduled jobs while running, I didn't know about the persistence. Maybe there should be a way the user can specify to not use any, so that it can be portable.

@MostafaSolimanMO
Copy link
Owner

We consider it and we will start working on make it available for Dart only project, Thank you!

@Ascenio Ascenio closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants