Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopped Working? #12

Open
apiep opened this issue Jul 3, 2019 · 5 comments
Open

Stopped Working? #12

apiep opened this issue Jul 3, 2019 · 5 comments
Labels
bug help wanted

Comments

@apiep
Copy link

apiep commented Jul 3, 2019

Error on the devtools (not sure if it coming from this extension)
image
@Mottie
Copy link
Owner

Mottie commented Jul 3, 2019

Hi @apiep!

Hmm, no it's not those errors causing the problem. It seems that in Firefox, the <head> doesn't include the attributes that the addon is targeting:

<head prefix="og: http://ogp.me/ns# fb: http://ogp.me/ns/fb# medium-com: http://ogp.me/ns/fb/medium-com#">

What's really weird is if I view-source on that page in Firefox vs Chrome, the HTML is completely different.

@Mottie Mottie added the bug label Jul 3, 2019
@Mottie
Copy link
Owner

Mottie commented Jul 4, 2019 •
edited

Ugh, I doubt I'll make this work... the content is "dynamically" loaded in Firefox; which I can get around; but then I realized that all the class names are useless:

2019-07-03 20_44_43-Developer Tools - Exploring Stack and IndexedStack in Flutter - Flutter Communit

See #11.

@Mottie
Copy link
Owner

Mottie commented Jul 4, 2019

Feedback I just sent to Medium:

Hi, I'm the author of the Darker-Medium browser (Chrome, Firefox & Opera) extension
(https://github.com/Mottie/Darker-Medium). Right now if I go to this page on my desktop
computer: https://medium.com/flutter-community/a-deep-dive-into-stack-in-flutter-3264619b3a77 -
the source HTML in Firefox is completely different than in Chrome (I didn't check any other
browsers). Firefox is being made to dynamically load all its content (why on a desktop?) and
thus it ends up with class names like "jp", "ec" & "kc". These classes also appear on all @
user profile pages. Please please please use some reasonable css class names on these
pages. Or, provide a dark theme that we can switch to when desired. Oh, and please tell
the designers/developers to not use !important flags in their css everywhere. It makes it
very difficult to create/update/apply style overrides to Medium story pages.

@Mottie
Copy link
Owner

Mottie commented Jul 6, 2019

Response from Medium:

Hi,

We are migrating our pages to a new stack, and this could be a result of that. (and the discrepancies you see could be a result of viewing the pages in different roll-out cohorts).

I will raise this issue to the team to investigate. Please bear with us.

@apiep
Copy link
Author

apiep commented Jul 11, 2019

It seems, they decide to use "modern frontend". That is why it's css selector are minified and I see a giant minified object when I try to inspect it source too.

And I am not sure what we can do about it except manually choose the correct element to style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mottie @apiep