Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting ops.spkTh during mainLoop #468

Closed
FilippoHei opened this issue Jan 17, 2022 · 1 comment · Fixed by #595
Closed

Overwriting ops.spkTh during mainLoop #468

FilippoHei opened this issue Jan 17, 2022 · 1 comment · Fixed by #595

Comments

@FilippoHei
Copy link

Hi there. After running Kilosort2 with a few different settings I noticed that the ops.spkTh variable is overwritten several times in the mainLoop (see picture). It is even commented with ops.spkTh = -6; % why am I overwriting this here?

image

So, is there a reason for this overwriting? I commented out the lines, and it worked just fine, with the additional benefit of being able to set the spkTh parameter myself.

@eintzandt
Copy link

I found that in the actual step that detects spikes based on thresholds it is also overwritten: main_kilosort.m line 29 -> datashift2.m line 27 "spkTh = 8" instead of "spkTh=ops.spkTh". Is there a reason for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants