Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enum for the types ? #9

Closed
u1735067 opened this issue Nov 8, 2016 · 2 comments
Closed

Use enum for the types ? #9

u1735067 opened this issue Nov 8, 2016 · 2 comments

Comments

@u1735067
Copy link

u1735067 commented Nov 8, 2016

I may have missed the explanation about this, but I wanted to understand the format used in tags.py and I had to find what is the second field, then try to see where those values are used. I figured out it's Type after following code.
Maybe a comment could be added to explain the format ?
Also I think the type specification system used, ie. list of integers, is hard to follow and should be written as enum if possible ?

Just my feedback from trying to understand how it works, but it might makes other/future maintainers life easier.

@u1735067
Copy link
Author

u1735067 commented Nov 9, 2016

Ok, I just completly missed https://github.com/Moustikitos/tyf/blob/master/Tyf/__init__.py#L14, nevermind :x

@u1735067 u1735067 closed this as completed Nov 9, 2016
@Moustikitos
Copy link
Owner

Hello,

I use integer list according to tiff spec, the data type is written in ifd entry as short in second position [type, type, count, offset_or_value].

ifd.py module definesTiffTag object that implements "tag behaviour"

thanks for using my lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants