Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placer upgrade stops when an area is designated and a block is present #255

Open
Mystara0001 opened this issue Dec 24, 2023 · 3 comments
Open
Assignees
Labels
Fixed In Dev [1.19] This Issue has been fixed, and will be in the next released build. QOL Fix TODO On the ToDo list

Comments

@Mystara0001
Copy link

I noticed that if you select multiple areas for placing a block, if one is occupied, the4 placer stops placing blocks until it can place a block in that space.

Set up a placer.
Set a work area card for a ten block row.
Place a block somewhere in the row
Activate the placer

Expected.
Placer reaches the occupied space and skips it going to the next to place a block.

Actual.
Placer reaches occupied space and then stops until the space is no longer occupied.

@Mystara0001 Mystara0001 changed the title Place upgrade stops when an area is designated Placer upgrade stops when an area is designated and a block is present Dec 24, 2023
@Mowmaster
Copy link
Owner

all upgrades that iterate through a list of spaces to enact work on act the exact same way. while in the case of a planter it might feel like a bug, if fixed it could cause things like the chopper/harvester/pump/quarry to skip spots and leave the whole area not processed.

@Mowmaster Mowmaster self-assigned this Jan 19, 2024
@Mowmaster Mowmaster added TODO On the ToDo list QOL Fix labels Jan 19, 2024
@Mowmaster
Copy link
Owner

22e55f7

@Mowmaster Mowmaster added the Fixed In Dev [1.19] This Issue has been fixed, and will be in the next released build. label Feb 21, 2024
@Nagapito
Copy link

Hi, your fix does not work for the block placer....

On line 124, you only iterate to the next position if player action returns true...
Issue is, on line 183, you check if the space is empty and if it isnt, you return false, so it never iterates to next position on 124....

Also, if I read it correctly, on line 124 you are negating the value of having the workpositionskip. This means if the pedestal is upgraded, it sends the value false. Later on player action, even if it bypasses the empty block check, since it cant place an item and consume the one on pedestal, it will return the skip variable, which will have false value and prevent again to iterate to next position.

So, I think line 183 should return the skip variable instead of false value and on line 124, you should remove the negator on last parameter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed In Dev [1.19] This Issue has been fixed, and will be in the next released build. QOL Fix TODO On the ToDo list
Projects
None yet
Development

No branches or pull requests

3 participants