You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It doesn't seem like a bad idea to me, but I can't imagine why the person who implemented the generics in Endpoint would do so for no reason. I think the easiest way to see why it's required is by attempting the PR. Maybe you'll find out if/why it can't be removed while attempting the change
@zhongwuzw I think @AndrewSB makes a good suggestion here. You can try and remove it by submitting a PR for this change. However, I can't guarantee it will be accepted.
I want to make a
PR
to remove generics ofEndpoint
. The reason based on:Endpoint
is a concrete class, and store some basic info about request. I cannot found any reason thatEndpoint
need uses generics.Maybe my thoughts is one-sided, please let me know if it is.:beers::beers:
The text was updated successfully, but these errors were encountered: