Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generics of Endpoint #1524

Closed
zhongwuzw opened this issue Jan 3, 2018 · 4 comments
Closed

Remove generics of Endpoint #1524

zhongwuzw opened this issue Jan 3, 2018 · 4 comments
Milestone

Comments

@zhongwuzw
Copy link
Member

I want to make a PR to remove generics of Endpoint. The reason based on:

Endpoint is a concrete class, and store some basic info about request. I cannot found any reason that Endpoint need uses generics.

Maybe my thoughts is one-sided, please let me know if it is.:beers::beers:

@SD10 SD10 added the discussion label Jan 3, 2018
@AndrewSB
Copy link
Member

AndrewSB commented Jan 5, 2018

It doesn't seem like a bad idea to me, but I can't imagine why the person who implemented the generics in Endpoint would do so for no reason. I think the easiest way to see why it's required is by attempting the PR. Maybe you'll find out if/why it can't be removed while attempting the change

@SD10
Copy link
Member

SD10 commented Jan 5, 2018

@zhongwuzw I think @AndrewSB makes a good suggestion here. You can try and remove it by submitting a PR for this change. However, I can't guarantee it will be accepted.

@SD10
Copy link
Member

SD10 commented Jan 18, 2018

#434 Is related

@sunshinejr
Copy link
Member

sunshinejr commented Jan 27, 2018

Closing this one. It's already ⛵️in Moya 11.0.0-beta.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants