Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xcode_summary to Danger to show build errors #1559

Closed
SD10 opened this issue Jan 30, 2018 · 5 comments
Closed

Add xcode_summary to Danger to show build errors #1559

SD10 opened this issue Jan 30, 2018 · 5 comments

Comments

@SD10
Copy link
Member

SD10 commented Jan 30, 2018

One thing I hate about CI failing is I have to go and dig through the build log. It would be great if we could use xcode_summary to propagate test failures and build errors.

Here is an example of it being used at the EZSwiftExtensions repo

@BasThomas
Copy link
Contributor

Oh wow, why have I not heard of this before?!

@SD10
Copy link
Member Author

SD10 commented Jun 7, 2018

@LucianoPAlmeida I'm tagging you because I see you setting this up for SwifterSwift/SwifterSwift#498. If you get it working would you be so kind as to see if it can be applied to Moya too? ❤️

@LucianoPAlmeida
Copy link
Member

For sure @SD10 :))
I just start running some tests to see how it works, let's see if I can put this to run there 😆

@LucianoPAlmeida
Copy link
Member

I think I can try to make this one on this weekend :))
Let's see if we can make this run 😊

@SD10
Copy link
Member Author

SD10 commented Jun 23, 2018

This was resolve in #1680. Awesome work!

@SD10 SD10 closed this as completed Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants