Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVCalendarView doesn't load on when Simulated Metric == iPhone 4-inch #46

Closed
gjones opened this issue Apr 15, 2015 · 3 comments
Closed
Assignees
Labels

Comments

@gjones
Copy link

gjones commented Apr 15, 2015

Hi there,
It seems when you have your view controller set to iPhone 4-inch in the storyboard, the calendarView doesn't load on devices older/smaller than the iPhone 6. Not sure why this is but you can test it in your new demo.

Steps to reproduce:

  • Open most recent version of demo in Xcode
  • Go to storyboard and select the viewController
  • Under attributes inspect, set size to iPhone 4-inch
  • Build and run on iPhone 5S.

Thought I'd save others a bunch of time by reporting it here.

@gjones
Copy link
Author

gjones commented Apr 15, 2015

Just to add to this, it looks as though the CVCalendarView fails to load whenever the simulated size matches the device size. For example setting the simulated size to iPhone 4.7-inch means it no longer loads on the iPhone 6, 5.5-inch doesn't show on the 6 Plus etc.

mozharovsky added a commit that referenced this issue Apr 15, 2015
* CVCalendar is properly displayed without Autolayout
@mozharovsky
Copy link
Member

Hello @gjones,

Thank you for the reported issue.

You're trying to use CVCalendarView that has a constant size as a result it doesn't update frames since they aren't changed. I've just pushed the code which should have fixed that issue. Please let me know if it works for you.

Regards,
Eugene

@mozharovsky mozharovsky self-assigned this Apr 15, 2015
@gjones
Copy link
Author

gjones commented Apr 17, 2015

@mozharovsky I see there's been lots of changes to the file structure since I reported this so it'll take me a bit of time migrate my app to the newer version and test out these updates. I did try the updated demo and the problem seemed to be fixed so I'm sure it is.

Thanks for responding so quickly and of course for the excellent CVCalendar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants