Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Disabled Button Style #3320

Closed
7 of 10 tasks
beccaklam opened this issue Jun 10, 2019 · 0 comments · Fixed by #3458
Closed
7 of 10 tasks

Implement Disabled Button Style #3320

beccaklam opened this issue Jun 10, 2019 · 0 comments · Fixed by #3458
Assignees
@mmmavis
Labels
frontend
Projects
Foundation Site
Milestone
Aug 5

Comments

@beccaklam
Copy link

beccaklam commented Jun 10, 2019 •
edited

We have defined some new button styles (more like filling in gaps we had before in our style guide) and they need to be implemented!

Disabled Button Style

  • Set opacity of button to 30% for normal buttons

  • 50% for inverse buttons.

  • Disabled buttons stay the same on hover

disabled-button-style@2x

Related ticket: MozillaFoundation/Design#371
Redpen: https://redpen.io/p/knefb82f90a4716342

🗒 Design -> Dev Handoff Checklist
(Feel free to remove items that are not applicable.)

  • Design has been finalized
  • Link to original design ticket
  • Link to related ticket
  • Link to Redpen
  • Design changes been merged into the master Sketch file
  • Desktop and mobile mockups are included
  • Hover state for elements are designed
@beccaklam beccaklam added this to Backlog in Foundation Site via automation Jun 10, 2019
@mmmavis mmmavis self-assigned this Jul 25, 2019
@mmmavis mmmavis added this to the Aug 5 milestone Jul 26, 2019
@mmmavis mmmavis moved this from Backlog to In Progress in Foundation Site Jul 27, 2019
@mmmavis mmmavis mentioned this issue Jul 27, 2019
Merged
@mmmavis mmmavis moved this from In Progress to In Review in Foundation Site Jul 27, 2019
Foundation Site automation moved this from In Review to Done Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
frontend
Projects
No open projects
Foundation Site
  
Done
Milestone
Aug 5
Development

Successfully merging a pull request may close this issue.

Implement disabled button style + example to style guide MozillaFoundation/foundation.mozilla.org
2 participants
@mmmavis @beccaklam