Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize production work for Privacy Day Campaign #246

Closed
OpenMatt opened this issue Jan 19, 2015 · 25 comments
Closed

Finalize production work for Privacy Day Campaign #246

OpenMatt opened this issue Jan 19, 2015 · 25 comments
Assignees
Labels
Milestone

Comments

@OpenMatt
Copy link

GOAL: Finish up & ship the production work. Some design & front-end tweaks to get the execution looking great. Then push it to staging / prod when ready. (requires: design / light front-end dev.)

Communications plan for how we'll promote this work once it's completed is here:
#226

Needs to ship on Jan 27th EOD

Because Privacy Day is Jan 28th

Owner: @secretrobotron
Responsible: @HPaulJohnson
Design Lead: @iamjessklein
Development Lead: @gesa
Quality Verifier: @cassiemc

@OpenMatt OpenMatt added this to the January 30 milestone Jan 19, 2015
@OpenMatt OpenMatt added the P1 label Jan 19, 2015
@OpenMatt
Copy link
Author

@iamjessklein : assigning to you, as per conversation with @cassiemc

@OpenMatt
Copy link
Author

moving from the other ticket for reference. @thisandagain said:

UI and execution needs QA prior to launch:
http://sleepy-ravine-9799.herokuapp.com/en-US/home-3

/cc @cassiemc @gesa @iamjessklein

@cassiemc
Copy link
Contributor

This project needs an owner and a kickoff, since it's p1. I think the previous owner was @HPaulJohnson but maybe I'm wrong? Still needs dev, too.

cc @thisandagain @OpenMatt @simonwex

@iamjessklein
Copy link

👍 In the meantime, is there a qa checklist that we can pull up to start getting prepped?

@iamjessklein
Copy link

Just talked to @secretrobotron and we think that we should break this into two parts:

  • Week 1: Design QA and finalizing
  • Week 2: Functional QA (Tech)

In order to do this - I am going to clean up the checklist that was used for onboarding qa and see if there is a checklist for design qa and turn them into a form to send participants. It would be great if the form could be like the intake form on build.webmaker.org - but don't need this to turn into a whole project.

@thisandagain
Copy link
Contributor

Hey @secretrobotron sorry for the late notice, but can you own this issue?

@OpenMatt
Copy link
Author

  • I've updated the RACI above, because I filed this out incorrectly to start (pending @thisandagain's question re: Bobby as owner)

@secretrobotron
Copy link
Contributor

@thisandagain 👍 on it.

@OpenMatt
Copy link
Author

  • Thanks Bobby. BTW: I don't need to attend the kick-off or be a part of the RACI on this ticket going forward. I just filed it. Now I'll get out of the way. :)

@secretrobotron
Copy link
Contributor

Haha acknowledged :).

@secretrobotron
Copy link
Contributor

Tracking progress in a webmaker.org milestone: https://github.com/mozilla/webmaker.org/milestones/Privacy%20Day

@secretrobotron
Copy link
Contributor

@secretrobotron
Copy link
Contributor

@HPaulJohnson @cassiemc wanna take a final look to see if anything can be fixed before tomorrow EOD?

@gesa
Copy link

gesa commented Jan 26, 2015

@secretrobotron I think you misspelled “Zaroo Boogs” 😉

@secretrobotron
Copy link
Contributor

@gesa good catch. thank you

@HPaulJohnson
Copy link

Everything looks good to me. Thx.

@cassiemc
Copy link
Contributor

A couple things but no deal breakers.
privateeye

  • the corners on the hex don't quite line up, and the edges still look a bit jagged (i'm looking in ff 36 mac). I didn't take a screenshot before but it does seem better than the last time I looked.
  • I think the animation would look better if it was two shapes (same color as the bkg) animating up and down over the eye (like real eyelids) vs. stretching the eyeball itself. for future reference if there's no time to adjust this now.
  • when the static animation transitions to the version where the eyeball follows my mouse there is a slight jump. not sure if anything could be done about that.

Looks really good though, it does the trick. Love the text, color and pattern updates. Nice work everyone!

@gesa
Copy link

gesa commented Jan 27, 2015

Hopefully this looks a little better on FF. I'm gonna ruminate on the eyelid thing. Idk if I'll get anywhere with that, but it'll be on my mind.
gukev

@gesa
Copy link

gesa commented Jan 27, 2015

Okay. Ruminated. Played around. How does this look? http://snaps.akibraun.com/blinking-eye.mov

@cassiemc
Copy link
Contributor

@gesa 💞 💥 😍 Looks awesome, you rock.

@iamjessklein
Copy link

Nice @gesa - solid. 👊

@secretrobotron
Copy link
Contributor

@gesa will push to prod in 2 hours. 🌳

@gesa
Copy link

gesa commented Jan 27, 2015

@iamjessklein
Copy link

It has landed!!!

giphy

@gesa
Copy link

gesa commented Jan 28, 2015

I wish I could “favorite” a github comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants