Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show history and bookmarks in awesomebar results #1257

Closed
jvonitter opened this issue May 23, 2019 · 7 comments · Fixed by #1425
Closed

Show history and bookmarks in awesomebar results #1257

jvonitter opened this issue May 23, 2019 · 7 comments · Fixed by #1425
Assignees
Labels
Final Design Design complete. Any request for design revision must open in a new issue. PM/UX review PM/UX review needed prior to merge task This issue is maintenance or an operational requirement UX Issue relates to UX
Milestone

Comments

@jvonitter
Copy link
Contributor

needs #1141

@jvonitter jvonitter added the task This issue is maintenance or an operational requirement label May 23, 2019
@jvonitter jvonitter added this to the v1.3 milestone May 23, 2019
@jvonitter jvonitter self-assigned this May 23, 2019
@jvonitter
Copy link
Contributor Author

jvonitter commented May 23, 2019

When a user begins to enter text into the awesomebar, the search results below should include sites that are in the user's history and bookmarks.
The sites should have a visual indication of whether they are history, bookmark or regular search results.

For reference, desktop Firefox shows this. We should align to it as much as makes sense.
showing history and bookmarks in the awesomebar

@jvonitter jvonitter added the Needs Design Attention design team label May 23, 2019
@jvonitter jvonitter modified the milestones: v1.3, v1.4 Jul 2, 2019
@jvonitter jvonitter added Final Design Design complete. Any request for design revision must open in a new issue. and removed Needs Design Attention design team labels Jul 8, 2019
@jvonitter
Copy link
Contributor Author

@jvonitter jvonitter removed their assignment Jul 10, 2019
@jvonitter jvonitter added the PM/UX review PM/UX review needed prior to merge label Jul 11, 2019
@keianhzo keianhzo self-assigned this Jul 15, 2019
@keianhzo
Copy link
Collaborator

keianhzo commented Jul 16, 2019

@thenadj I can't find the icons in the spec, can you add them to the Trello card above? It's only the history one, unless the bookmarks one is any different from the current bookmarks icon that we are using in the navigation bar.

@thenadj
Copy link

thenadj commented Jul 16, 2019

We're using the same icon as for the tray. Use this one:
icon-tray-history.svg.zip

@keianhzo
Copy link
Collaborator

@jvonitter @thenadj You can review the new awesome bar spec here that includes support for showing and filtering bookmark and history entries in the awesome bar:
https://send.firefox.com/download/9a58bce1a376fd73/#ZZSzGHI_kuZlWKcfKufDug

@keianhzo
Copy link
Collaborator

@thenadj Latest APK with the icon style updates: https://send.firefox.com/download/c42b67bfaee99b45/#STSKCHP3B9fn7vDeNLAI-Q

@thenadj
Copy link

thenadj commented Jul 19, 2019

Looks good, thank you!

@jvonitter jvonitter added QA Attention QA UX Issue relates to UX labels Aug 15, 2019
@Softvision-GeluHaiduc Softvision-GeluHaiduc removed the QA Attention QA label Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Design Design complete. Any request for design revision must open in a new issue. PM/UX review PM/UX review needed prior to merge task This issue is maintenance or an operational requirement UX Issue relates to UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants