Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in VRBrowserActivity.onStop() #1492

Closed
bluemarvin opened this issue Aug 2, 2019 · 1 comment · Fixed by #1501
Closed

Crash in VRBrowserActivity.onStop() #1492

bluemarvin opened this issue Aug 2, 2019 · 1 comment · Fixed by #1501
Assignees
@MortimerGoro
Labels
bug This issue is a software or functional defect crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak
Milestone
v1.4

Comments

@bluemarvin
Copy link
Contributor

Hardware

Seen on Go, possibly other devices.

Steps to Reproduce

  1. Launch release build of FxR
  2. Let device go into sleep mode

Current Behavior

FxR crashes in VRBrowserActivity.onStop()
See: https://crash-stats.mozilla.com/report/index/c3c976c4-c637-4574-9a30-10a100190802

Expected Behavior

FxR should not crash on stop.

Possible Solution

Guessing this might be an R8 issue since it is only seen in release builds.
@bluemarvin bluemarvin added the crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak label Aug 2, 2019
@bluemarvin bluemarvin added this to the v1.4 milestone Aug 2, 2019
@bluemarvin
Copy link
Contributor Author

Crash still occurs with android.enableR8.fullMode=true disabled.

@philip-lamb philip-lamb added bug This issue is a software or functional defect P1 Fix in the current development iteration labels Aug 4, 2019
@MortimerGoro MortimerGoro mentioned this issue Aug 5, 2019
Merged
@philip-lamb philip-lamb removed the P1 Fix in the current development iteration label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MortimerGoro MortimerGoro

Labels
bug This issue is a software or functional defect crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Keep classes used by gson MozillaReality/FirefoxReality
3 participants
@bluemarvin @MortimerGoro @philip-lamb