Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support haptic feedback in immersive mode of HTC Vive Focus #173

Closed
kearwood opened this issue Jul 16, 2018 · 6 comments · Fixed by #2198
Closed

Support haptic feedback in immersive mode of HTC Vive Focus #173

kearwood opened this issue Jul 16, 2018 · 6 comments · Fixed by #2198
Assignees
@daoshengmu
Labels
enhancement This issue is a new feature or request platform:WaveVR Issues specific to the HTC WaveVR platform
Projects
FxR planning master
Milestone
#8 features

Comments

@kearwood
Copy link
Contributor

This will be dependent on Bugzilla Bug 1473397 - Add Haptic Feedback support to gfxVRExternal and VRSessionOpenVR
@kearwood kearwood added the enhancement This issue is a new feature or request label Jul 16, 2018
@nancyhang nancyhang added P1 Fix in the current development iteration P2 Fix in the next development iteration and removed P1 Fix in the current development iteration labels Jul 18, 2018
@nancyhang nancyhang added this to To do in v1.0 Jul 18, 2018
@larsbergstrom larsbergstrom removed this from To do in v1.0 Sep 8, 2018
@nancyhang nancyhang added this to Unprioritized in FxR planning master Oct 12, 2018
@nancyhang nancyhang moved this from Unprioritized to To do in FxR planning master Oct 13, 2018
@avrignaud avrignaud moved this from To do to Backlog in FxR planning master Nov 1, 2018
@cvan cvan added P3 Backlog and removed P2 Fix in the next development iteration labels Nov 27, 2018
@philip-lamb philip-lamb added the platform:WaveVR Issues specific to the HTC WaveVR platform label Feb 27, 2019
@philip-lamb
Copy link
Contributor

https://bugzilla.mozilla.org/show_bug.cgi?id=1473397 is resolved fixed.

@philip-lamb philip-lamb added this to the v1.2 milestone Feb 27, 2019
@philip-lamb
Copy link
Contributor

#676 (comment)

This was referenced Mar 11, 2019
Closed
Open
Open
@philip-lamb
Copy link
Contributor

Pushing to 1.3.

@philip-lamb philip-lamb modified the milestones: v1.2, v1.3 May 2, 2019
@jvonitter jvonitter modified the milestones: v1.3, v1.x May 20, 2019
@daoshengmu daoshengmu self-assigned this Aug 30, 2019
@daoshengmu
Copy link
Contributor

daoshengmu commented Aug 30, 2019 •
edited

I am going to work on it next week.

WaveVR: WVR_TriggerVibration (https://hub.vive.com/storage/docs/en-us/WVR_TriggerVibration.html)

Oculus: vrapi_SetHapticVibrationBuffer
(https://developer.oculus.com/reference/mobile/1.25/vr_api_input_8h)

@daoshengmu
Copy link
Contributor

In WaveVR, the current code flow doesn't enter VRManager::VibrateHaptic, so External VR state of browser.hapticState is always zero.

I guess it is because GamepadHapticActuator length is zero when using standalone headsets. I will revisit and figure out it at FxR v1.6.

@jvonitter jvonitter modified the milestones: v1.x, v1.6 Sep 9, 2019
@jvonitter jvonitter modified the milestones: #6 features, #7 polish Oct 2, 2019
@daoshengmu daoshengmu mentioned this issue Nov 8, 2019
Merged
@jvonitter jvonitter modified the milestones: #7 polish, #8 features Nov 27, 2019
@daoshengmu
Copy link
Contributor

I saw there is a bug from the Gecko side when re-entering WebVR page. It can be reproduced by Firefox Desktop. We will address this issue there, https://bugzilla.mozilla.org/show_bug.cgi?id=1605788.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daoshengmu daoshengmu

Labels
enhancement This issue is a new feature or request platform:WaveVR Issues specific to the HTC WaveVR platform
Projects
No open projects
FxR planning master
  
Backlog
Milestone
#8 features
Development

Successfully merging a pull request may close this issue.

Making WaveVR/OculusVR controllers support haptic feedback MozillaReality/FirefoxReality
6 participants
@cvan @daoshengmu @kearwood @philip-lamb @nancyhang @jvonitter